[
https://issues.apache.org/jira/browse/YARN-5635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15488977#comment-15488977
]
Vinod Kumar Vavilapalli commented on YARN-5635:
-----------------------------------------------
I'm deliberately staying out of the technical details here though I do have
strong opinions on this.
[~aw]
bq. YARN-5567 has already been reverted.
I saw YARN-5567 also where the patch was reverted even though there was no ack
from the original contributor / committer.
Please don't do this.
Even if there are differing opinions, you should give a heads up, wait and then
revert something. This isn't something that needs to be coded into the bylaws,
it's basic etiquette. There is no reason for a unilateral revert without
discussion.
bq. I'm going to -1 any patch that even thinks about treating the exit code as
a way to mark the NM as unhealthy.
This isn't constructive tone either, you could have simply said it isn't the
right solution and provided alternatives. By this tone, you are essentially
shooing away interested volunteers from the project.
> Better handling when bad script is configured as Node's HealthScript
> --------------------------------------------------------------------
>
> Key: YARN-5635
> URL: https://issues.apache.org/jira/browse/YARN-5635
> Project: Hadoop YARN
> Issue Type: Bug
> Reporter: Allen Wittenauer
> Assignee: Yufei Gu
>
> Earlier fix to YARN-5567 is reverted because its not ideal to get the whole
> cluster down because of a bad script. At the same time its important to
> report that script is erroneous which is configured as node health script as
> it might miss to detect bad health of a node.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
