[ 
https://issues.apache.org/jira/browse/YARN-3140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15493012#comment-15493012
 ] 

Jian He commented on YARN-3140:
-------------------------------

- Is this method not used ? If so, labelManager no need to be volatile, and 
remove this method
{code}
  @VisibleForTesting
  public void setNodeLabelManager(RMNodeLabelsManager mgr) {
    this.labelManager = mgr;
  }
  {code}
- pendingOrderingPolicy: no need to be volatile 
- This synchronized keyword is removed, but no write lock is added
{code}
  private synchronized CSAssignment assignContainersToChildQueues(
  {code}

> Improve locks in AbstractCSQueue/LeafQueue/ParentQueue
> ------------------------------------------------------
>
>                 Key: YARN-3140
>                 URL: https://issues.apache.org/jira/browse/YARN-3140
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager, scheduler
>            Reporter: Wangda Tan
>            Assignee: Wangda Tan
>         Attachments: YARN-3140.1.patch, YARN-3140.2.patch
>
>
> Enhance locks in AbstractCSQueue/LeafQueue/ParentQueue, as mentioned in 
> YARN-3091, a possible solution is using read/write lock. Other fine-graind 
> locks for specific purposes / bugs should be addressed in separated tickets.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to