[
https://issues.apache.org/jira/browse/YARN-3141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15494159#comment-15494159
]
Wangda Tan commented on YARN-3141:
----------------------------------
Thanks for review, [~templedf],
I addressed all your suggestions except:
bq. You axed the javadoc for SchedulerApplicationAttempt.isReserved()
isReserved is not used by anyone, so I removed that method
bq. It would be nice in the javadoc for all the methods that are no longer
synchronized to note that they're MT safe.
This is a good suggestion, but I think it's better to come in a separate patch,
since we have to update almost every method in scheduler.
Any other thoughts?
(Attached ver.3 patch)
> Improve locks in SchedulerApplicationAttempt/FSAppAttempt/FiCaSchedulerApp
> --------------------------------------------------------------------------
>
> Key: YARN-3141
> URL: https://issues.apache.org/jira/browse/YARN-3141
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: resourcemanager, scheduler
> Reporter: Wangda Tan
> Assignee: Wangda Tan
> Attachments: YARN-3141.1.patch, YARN-3141.2.patch, YARN-3141.3.patch
>
>
> Enhance locks in SchedulerApplicationAttempt/FSAppAttempt/FiCaSchedulerApp,
> as mentioned in YARN-3091, a possible solution is using read/write lock.
> Other fine-graind locks for specific purposes / bugs should be addressed in
> separated tickets.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
