[ 
https://issues.apache.org/jira/browse/YARN-3141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Wangda Tan updated YARN-3141:
-----------------------------
    Attachment: YARN-3141.6.patch

Thanks [~templedf], 

Even though most of checkstyle warnings are not related to the patch,  I fixed 
most of them in ver.6.

Only a couple of checkstyle which complains:
bq. .. Variable 'queue' must be private and have accessor methods.

We defines some variables like queue/stopped in base class 
(SchedulerApplicationAttempt) in protected. And we use these variables in 
inherited classes. I think it makes code to be more complex If we define 
methods like getQueue() to force sub class use these method. I would prefer to 
not change them.

Thoughts?

> Improve locks in SchedulerApplicationAttempt/FSAppAttempt/FiCaSchedulerApp
> --------------------------------------------------------------------------
>
>                 Key: YARN-3141
>                 URL: https://issues.apache.org/jira/browse/YARN-3141
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager, scheduler
>            Reporter: Wangda Tan
>            Assignee: Wangda Tan
>         Attachments: YARN-3141.1.patch, YARN-3141.2.patch, YARN-3141.3.patch, 
> YARN-3141.4.patch, YARN-3141.5.patch, YARN-3141.6.patch
>
>
> Enhance locks in SchedulerApplicationAttempt/FSAppAttempt/FiCaSchedulerApp, 
> as mentioned in YARN-3091, a possible solution is using read/write lock. 
> Other fine-graind locks for specific purposes / bugs should be addressed in 
> separated tickets.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to