[
https://issues.apache.org/jira/browse/YARN-5587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15505104#comment-15505104
]
Arun Suresh commented on YARN-5587:
-----------------------------------
[~vvasudev], I agree with Wangda.. splitting this would make it easier to
review.
One thing I did notice when skimming over the patch is that we should probably
have a more consistent way for implementing hashcode/equals and toString in our
PB classes.
We have a bunch of places where the hashcode/equals/toString are implemented in
the abstract class (for eg. {{ResourceRequest}}) and there are places where it
is defined in the subclass (for eg. {{ResourceLocalizationRequestPBImpl}}).
I tend to prefer the latter since it is reverts to the proto/builders
implementation, which is autogenerated and something I would trust to be
correct. The former is hand-coded and error prone.
Thoughts ?
> Add support for resource profiles
> ---------------------------------
>
> Key: YARN-5587
> URL: https://issues.apache.org/jira/browse/YARN-5587
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: nodemanager, resourcemanager
> Reporter: Varun Vasudev
> Assignee: Varun Vasudev
> Attachments: YARN-5587-YARN-3926.001.patch,
> YARN-5587-YARN-3926.002.patch, YARN-5587-YARN-3926.003.patch
>
>
> Add support for resource profiles on the RM side to allow users to use
> shorthands to specify resource requirements.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
