Jian He commented on YARN-5609:

Thanks Arun, some more comments:
- IIUC, when restarting the container, the  {{reInitEvent.getResourceSet()}} is 
      ContainerLaunchContext launchContext =
          reInitEvent.getReInitLaunchContext() == null ?
              container.launchContext : reInitEvent.getReInitLaunchContext();
      return new ReInitializationContext(
          launchContext, reInitEvent.getResourceSet(),
and later on, here it will return empty newResourceSet because oldLaunchContext 
is null? and this caused the container restarted with incorrect symlinks.  do 
you mind adding a UT for restart container too ?
    private ResourceSet mergedResourceSet() {
      if (oldLaunchContext == null) {
        return newResourceSet;
-  should we add some success/failure audit log to the API ?
bq.  Wondering if we need to also ensure that only the application that started 
the container can reinitialize it.
yeah, I agree.

> Expose upgrade and restart API in ContainerManagementProtocol
> -------------------------------------------------------------
>                 Key: YARN-5609
>                 URL: https://issues.apache.org/jira/browse/YARN-5609
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Arun Suresh
>            Assignee: Arun Suresh
>         Attachments: YARN-5609.001.patch, YARN-5609.002.patch
> YARN-5620 and YARN-5637 allows an AM to explicitly *upgrade* a container with 
> a new launch context and subsequently *rollback* / *commit* the change on the 
> Container. This can also be used to simply *restart* the Container as well. 
> This JIRA proposes to extend the ContainerManagementProtocol with the 
> following API:
> * *upgradeContainer*
> * *rollbackLastUpgrade*
> * *commitLastUpgrade*
> * *restartContainer*

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to