Sunil G commented on YARN-4855:

Thanks [~Tao Jie] and [~Naganarasimha] for taking the discussions forward.

We already support sub options as below.
[-refreshNodes [-g|graceful [timeout in seconds] -client|server]]
So i think *"-fail-on-unknown-nodes"* makes more sense to me. However, 
generally RMAdminCLI options are using camel casing. And we are not supporting 
much of sub-options till now here unlike in ApplicationCLI. And ApplicationCLI 
already has {{appStates}} etc. So may be we could make this sub option like 

> Should check if node exists when replace nodelabels
> ---------------------------------------------------
>                 Key: YARN-4855
>                 URL: https://issues.apache.org/jira/browse/YARN-4855
>             Project: Hadoop YARN
>          Issue Type: Improvement
>    Affects Versions: 2.6.0
>            Reporter: Tao Jie
>            Assignee: Tao Jie
>            Priority: Minor
>         Attachments: YARN-4855.001.patch, YARN-4855.002.patch, 
> YARN-4855.003.patch, YARN-4855.004.patch, YARN-4855.005.patch, 
> YARN-4855.006.patch, YARN-4855.007.patch, YARN-4855.008.patch, 
> YARN-4855.009.patch, YARN-4855.010.patch, YARN-4855.011.patch, 
> YARN-4855.012.patch
> Today when we add nodelabels to nodes, it would succeed even if nodes are not 
> existing NodeManger in cluster without any message.
> It could be like this:
> When we use *yarn rmadmin -replaceLabelsOnNode --fail-on-unkown-nodes 
> "node1=label1"* , it would be denied if node is unknown.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to