[ 
https://issues.apache.org/jira/browse/YARN-4493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15508157#comment-15508157
 ] 

Daniel Templeton commented on YARN-4493:
----------------------------------------

Looks generally good to me.  Thanks, [~yufeigu]!  Please complete the javadocs 
for the methods you added, i.e. params, returns, etc.  Also, as was suggested 
before, some unit tests would be good to add.

> move queue can make app don't belong to any queue
> -------------------------------------------------
>
>                 Key: YARN-4493
>                 URL: https://issues.apache.org/jira/browse/YARN-4493
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: fairscheduler
>    Affects Versions: 2.4.0, 2.6.0, 2.7.1
>            Reporter: jiangyu
>            Assignee: Yufei Gu
>            Priority: Minor
>         Attachments: YARN-4493.001.patch, yarn-4493.patch.1
>
>
> When moving a running application to a different queue, the current implement 
> don't check if the app can run in the new queue before remove it from current 
> queue. So if the destination queue is full, the app will throw exception, and 
> don't belong to any queue.    
> After that, the queue become orphane, can not schedule any resources. If you 
> kill the app,  the removeApp method in FSLeafQueue will throw 
> IllealStateException of "Given app to remove app does not exist in queue ..." 
> exception.   
> So i think we should check if the destination queue can run the app before 
> remove it from the current queue.  
> The patch is from our revision.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to