[
https://issues.apache.org/jira/browse/YARN-5659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15508231#comment-15508231
]
Junping Du commented on YARN-5659:
----------------------------------
Thanks [~templedf] for review and comments! Patch looks OK to me but I agree
with Daniel that we should add a simple unit test for a normal URL and URL
without scheme (that you mentioned a bug exists so far).
+1 when adding UT there.
> getPathFromYarnURL should use standard methods
> ----------------------------------------------
>
> Key: YARN-5659
> URL: https://issues.apache.org/jira/browse/YARN-5659
> Project: Hadoop YARN
> Issue Type: Bug
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Attachments: YARN-5659.patch
>
>
> getPathFromYarnURL does some string shenanigans where standard ctors should
> suffice.
> There are also bugs in it e.g. passing an empty scheme to the URI ctor is
> invalid, null should be used.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
