Jian He commented on YARN-5609:

I had re-checked the code... actually, even the old resources will also not be 
purged because in the container reInit state-machine we are never sending the 
cleanup event, and the background cleanup thread also cannot purge it, because 
the resource is still considered being used by the container (refCount > 0).  
I think it's an ok assumption to keep two versions of resources current and 
previous. Code is also simpler.. We probably need a followup patch to let the 
background cleanup thread clean the resourceSet older than the last. User 
anyway has to provide the full set of resources via the reInit API if they want 
to rollback to older than last. what do you think...

> Expose upgrade and restart API in ContainerManagementProtocol
> -------------------------------------------------------------
>                 Key: YARN-5609
>                 URL: https://issues.apache.org/jira/browse/YARN-5609
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Arun Suresh
>            Assignee: Arun Suresh
>         Attachments: YARN-5609.001.patch, YARN-5609.002.patch, 
> YARN-5609.003.patch, YARN-5609.004.patch, YARN-5609.005.patch, 
> YARN-5609.006.patch, YARN-5609.007.patch
> YARN-5620 and YARN-5637 allows an AM to explicitly *upgrade* a container with 
> a new launch context and subsequently *rollback* / *commit* the change on the 
> Container. This can also be used to simply *restart* the Container as well. 
> This JIRA proposes to extend the ContainerManagementProtocol with the 
> following API:
> * *reInitializeContainer*
> * *rollbackLastUpgrade*
> * *commitLastUpgrade*
> * *restartContainer*

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to