[ 
https://issues.apache.org/jira/browse/YARN-5104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15510937#comment-15510937
 ] 

Daniel Templeton commented on YARN-5104:
----------------------------------------

The new assert doesn't make sense.  The _catch_ guarantees that the exception 
will be an instance of {{IOException}}.

> TestNMProxy.testNMProxyRPCRetry failed
> --------------------------------------
>
>                 Key: YARN-5104
>                 URL: https://issues.apache.org/jira/browse/YARN-5104
>             Project: Hadoop YARN
>          Issue Type: Test
>    Affects Versions: 2.9.0
>            Reporter: Yufei Gu
>            Assignee: Yufei Gu
>              Labels: test
>         Attachments: YARN-5104.001.patch
>
>
> TestNMProxy.testNMProxyRPCRetry throws an exception and expected to be caught 
> and handled. 
> YARN-4916 did handle this exception:
> {code}
> java.net.BindException: Problem binding to [xxx] java.net.BindException: 
> Can't assign requested address; For more details see:  
> http://wiki.apache.org/hadoop/BindException
> {code}
> But it can also throw 
> {code}
> java.io.IOException: Failed on local exception: java.net.SocketException: 
> Invalid argument; Host Details : local host is: "xxx"; destination host is: 
> "1234":0; "
> {code}
> and this failed YARN-4916 with following message.
> {code}
> Error Message:
> null
> Stack Trace:
> java.lang.AssertionError: null
> at org.junit.Assert.fail(Assert.java:86)
> at org.junit.Assert.assertTrue(Assert.java:41)
> at org.junit.Assert.assertTrue(Assert.java:52)
> at 
> org.apache.hadoop.yarn.server.nodemanager.containermanager.TestNMProxy.testNMProxyRPCRetry(TestNMProxy.java:192)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to