[ 
https://issues.apache.org/jira/browse/YARN-5609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15512108#comment-15512108
 ] 

Jian He commented on YARN-5609:
-------------------------------

bq. during rollback, we should not merge the current resourceSet with new one.. 
it should just be replaced
The original 006 patch, it seems not merging,
so when it creates the rollback context, it sets the oldLaunchContext to null; 
{code}
        return new ReInitializationContext(
            oldLaunchContext, oldResourceSet, null, null);
      }
{code}
And in the mergedResourceSet
It returns  newResourceSet if oldLaunchContext is null
{code}
     if (oldLaunchContext == null) {
        return newResourceSet;
      }
{code} 
Am I right?

> Expose upgrade and restart API in ContainerManagementProtocol
> -------------------------------------------------------------
>
>                 Key: YARN-5609
>                 URL: https://issues.apache.org/jira/browse/YARN-5609
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Arun Suresh
>            Assignee: Arun Suresh
>         Attachments: YARN-5609.001.patch, YARN-5609.002.patch, 
> YARN-5609.003.patch, YARN-5609.004.patch, YARN-5609.005.patch, 
> YARN-5609.006.patch, YARN-5609.007.patch, YARN-5609.008.patch
>
>
> YARN-5620 and YARN-5637 allows an AM to explicitly *upgrade* a container with 
> a new launch context and subsequently *rollback* / *commit* the change on the 
> Container. This can also be used to simply *restart* the Container as well. 
> This JIRA proposes to extend the ContainerManagementProtocol with the 
> following API:
> * *reInitializeContainer*
> * *rollbackLastUpgrade*
> * *commitLastUpgrade*
> * *restartContainer*



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to