[ 
https://issues.apache.org/jira/browse/YARN-5525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15517484#comment-15517484
 ] 

Subru Krishnan commented on YARN-5525:
--------------------------------------

Thanks [~botong] for working on this. I took a look at the patch and want to 
understand your reasoning behind making the whole {{LogAggregationService}} 
pluggable as I feel we can achieve the intent of the JIRA by simply making 
{{AppLogAggregator}} implementation pluggable in {{LogAggregationService}}? 
This should be much simpler/cleaner to do as it's limited to 
*LogAggregationService::initAppAggregator*.

> Make log aggregation service class configurable
> -----------------------------------------------
>
>                 Key: YARN-5525
>                 URL: https://issues.apache.org/jira/browse/YARN-5525
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: log-aggregation
>            Reporter: Giovanni Matteo Fumarola
>            Assignee: Botong Huang
>            Priority: Minor
>         Attachments: YARN-5525.v1.patch, YARN-5525.v2.patch, 
> YARN-5525.v3.patch
>
>
> Make the log aggregation class configurable and extensible, so that 
> alternative log aggregation behaviors like app specific log aggregation 
> directory, log aggregation format can be implemented and plugged in.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to