[ 
https://issues.apache.org/jira/browse/YARN-5609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15518181#comment-15518181
 ] 

Arun Suresh commented on YARN-5609:
-----------------------------------

So, the container.setIsReInitializing(false) statements were remanants of when 
we did not have the REINITIALIZING state.. We don't really need it anymore.

bq.  if we add both metrics.reInitingContainer and 
metrics.endReInitingContainer into the setIsReInitializing method on top of 
original, that may work..
The setReinitializing(true) was meant to deal with the race condition between 
the ContainerManager API and the Container. It technically does not signify the 
start of a reinitialization.. that is actually triggered either in the 
{{ReInitializationTransition}} or in the {{RetryFailureTransition}} before 
rollback... 
That said, im not very particular about it... I can update the patch coincide 
the metric with the setReInit call from the API.

> Expose upgrade and restart API in ContainerManagementProtocol
> -------------------------------------------------------------
>
>                 Key: YARN-5609
>                 URL: https://issues.apache.org/jira/browse/YARN-5609
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Arun Suresh
>            Assignee: Arun Suresh
>         Attachments: YARN-5609.001.patch, YARN-5609.002.patch, 
> YARN-5609.003.patch, YARN-5609.004.patch, YARN-5609.005.patch, 
> YARN-5609.006.patch, YARN-5609.007.patch, YARN-5609.008.patch, 
> YARN-5609.009.patch
>
>
> YARN-5620 and YARN-5637 allows an AM to explicitly *upgrade* a container with 
> a new launch context and subsequently *rollback* / *commit* the change on the 
> Container. This can also be used to simply *restart* the Container as well. 
> This JIRA proposes to extend the ContainerManagementProtocol with the 
> following API:
> * *reInitializeContainer*
> * *rollbackLastUpgrade*
> * *commitLastUpgrade*
> * *restartContainer*



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to