[
https://issues.apache.org/jira/browse/YARN-5554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15525405#comment-15525405
]
Yufei Gu commented on YARN-5554:
--------------------------------
Thanks [~wilfreds]'s new patch. It makes sense to not introduce more
dependencies. Some nits:
1.
{code}
/*
* Check access to a targetQueue in the case of a move of an application
{code}
The first line should be {{/**}}.
2. I am wondering
{code}
if (scheduler instanceof CapacityScheduler) {
...
} else if (scheduler instanceof FairScheduler) {
...
} else {
return ...
}
{code} will be more readable.
3. In func {{moveApplicationAcrossQueues}}, can we use {{ioe.toString()}}
instead of {{"Target queue does not exist " + targetQueue}}?
> MoveApplicationAcrossQueues does not check user permission on the target queue
> ------------------------------------------------------------------------------
>
> Key: YARN-5554
> URL: https://issues.apache.org/jira/browse/YARN-5554
> Project: Hadoop YARN
> Issue Type: Bug
> Components: resourcemanager
> Affects Versions: 2.7.2
> Reporter: Haibo Chen
> Assignee: Wilfred Spiegelenburg
> Attachments: YARN-5554.2.patch, YARN-5554.3.patch, YARN-5554.4.patch,
> YARN-5554.5.patch
>
>
> moveApplicationAcrossQueues operation currently does not check user
> permission on the target queue. This incorrectly allows one user to move
> his/her own applications to a queue that the user has no access to
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
