[
https://issues.apache.org/jira/browse/YARN-5659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15530407#comment-15530407
]
Hitesh Shah edited comment on YARN-5659 at 9/28/16 6:06 PM:
------------------------------------------------------------
[~sershe] Just annotate the functions that are only required by unit tests with
@Private and @VisibleForTesting . In this case, the simplest approach would to
use the above annotations for all the new functions that are added as part of
this patch.
was (Author: hitesh):
[~sershe] Just annotate the functions that are only required by unit tests with
@Private and @VisibleForTesting
> getPathFromYarnURL should use standard methods
> ----------------------------------------------
>
> Key: YARN-5659
> URL: https://issues.apache.org/jira/browse/YARN-5659
> Project: Hadoop YARN
> Issue Type: Bug
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Attachments: YARN-5659.01.patch, YARN-5659.02.patch,
> YARN-5659.03.patch, YARN-5659.04.patch, YARN-5659.04.patch, YARN-5659.patch
>
>
> getPathFromYarnURL does some string shenanigans where standard ctors should
> suffice.
> There are also bugs in it e.g. passing an empty scheme to the URI ctor is
> invalid, null should be used.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
