[
https://issues.apache.org/jira/browse/YARN-5610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15534283#comment-15534283
]
Gour Saha commented on YARN-5610:
---------------------------------
[~jianhe] addressing your 3rd set of comments.
{quote}
I would prefer rename as such pair STARTED -> READAY, or RUNNING -> READY
{quote}
Makes sense. Renamed RUNNING -> READY. Also removed FINISHED as you suggested
before.
{quote}
Do you mean swagger has such a date type in string format ? which one is this?
I couldn't find it in swagger documentation.
{quote}
No, I meant that our REST API yaml document specifies the expected and
supported format of lifetime to be like "30mins, 10hours, 5days".
{quote}
I meant what is this change used for ?
{noformat}
<scm>
<url>http://git-wip-us.apache.org/repos/asf/hadoop.git</url>
<connection>
scm:git:http://git-wip-us.apache.org/repos/asf/hadoop.git
</connection>
<developerConnection>
scm:git:http://git-wip-us.apache.org/repos/asf/hadoop.git
</developerConnection>
</scm>
{noformat}
{quote}
The buildnumber-maven-plugin needs the scm url to be defined. Hence I had to
add those lines. Anyway I removed the buildnumber-maven-plugin for now, and
removed the scm section as well.
{quote}
I see. Then the if (uniqueGlobalPropertyCache == null) condition is not
needed, because uniqueGlobalPropertyCache is initialized as not null.
{noformat}
private void addOptionsIfNotPresent(List<String> options,
Set<String> uniqueGlobalPropertyCache, String key, String value) {
if (uniqueGlobalPropertyCache == null) {
options.addAll(Arrays.asList(key, value));
}
{noformat}
{quote}
In the current call to addOptionsIfNotPresent, uniqueGlobalPropertyCache is
initialized. But there could be other callers later, who might not initialize
it. The method has 2 different code paths - when uniqueGlobalPropertyCache is
null (caller does not want to use cache) vs when uniqueGlobalPropertyCache is
not-null (caller wants to use cache).
{quote}
Then, what are the other parameters in Component used for in this case ? like
number_of_containers, launch_command, resource etc.
{quote}
They are not required for external APPLICATION type.
> Initial code for native services REST API
> -----------------------------------------
>
> Key: YARN-5610
> URL: https://issues.apache.org/jira/browse/YARN-5610
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Gour Saha
> Assignee: Gour Saha
> Attachments: YARN-4793-yarn-native-services.001.patch,
> YARN-5610-yarn-native-services.002.patch
>
>
> This task will be used to submit and review patches for the initial code drop
> for the native services REST API
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
