[ 
https://issues.apache.org/jira/browse/YARN-5678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15536507#comment-15536507
 ] 

Yufei Gu commented on YARN-5678:
--------------------------------

For the hadoop QA's comment, I don't think it's necessary to add additional 
unit tests for this patch.

> Misleading log message in FSLeafQueue and FSParentQueue
> -------------------------------------------------------
>
>                 Key: YARN-5678
>                 URL: https://issues.apache.org/jira/browse/YARN-5678
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: fairscheduler
>    Affects Versions: 3.0.0-alpha1
>            Reporter: Yufei Gu
>            Assignee: Yufei Gu
>         Attachments: YARN-5678.001.patch
>
>
> {code}  
> private void updateDemandForApp(FSAppAttempt sched, Resource maxRes) {
>     sched.updateDemand();
>     Resource toAdd = sched.getDemand();
>     if (LOG.isDebugEnabled()) {
>       LOG.debug("Counting resource from " + sched.getName() + " " + toAdd
>           + "; Total resource consumption for " + getName() + " now "
>           + demand);
>     }
>     demand = Resources.add(demand, toAdd);
>     demand = Resources.componentwiseMin(demand, maxRes);
>   }
> {code}
> Change the "resource consumption" to "resource demand", since at that time 
> resources haven't been consumed yet.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to