[
https://issues.apache.org/jira/browse/YARN-5375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15538216#comment-15538216
]
sandflee commented on YARN-5375:
--------------------------------
Thanks [~rohithsharma] for your review !
bq. private volatile boolean drained = true; default value has been changed.
Would you tell why this change required?
to be consistent with AsyncDispatcher#drained. and seems a default value of
true is more reasonable.
bq. I think change in the method static to non-static not necessarily required
in MockRM#waitForState. Lets keep it as it is. As a result, MockAM
modifications are not at all required.
change from static to non-static is to add drainEventsImplicitly(). if keep it
as it is, the invoker (MockAM) maybe have to explicitly call rm#drainEvents
bq. nit: couple of changes which are not modified are appeared in patch. May be
check those also, else patch looks very huge. Ex : MockRM class, line no 349,
332
will do
bq. One doubt, if once * disableDrainEventsImplicitly* set then there is no way
to enable it. Should we provide enabling method also?
couldn't figure out the scene to disable and then enable, but I'm ok to add
enable method
bq. After this patch, can sleeps can be avoided ? If yes, I think we need to
remove so that test execute faster.
yes, after drainEvents, all events are processed, no need to sleep-wait anymore
> invoke MockRM#drainEvents implicitly in MockRM methods to reduce test failures
> ------------------------------------------------------------------------------
>
> Key: YARN-5375
> URL: https://issues.apache.org/jira/browse/YARN-5375
> Project: Hadoop YARN
> Issue Type: Improvement
> Reporter: sandflee
> Assignee: sandflee
> Attachments: YARN-5375.01.patch, YARN-5375.03.patch,
> YARN-5375.04.patch, YARN-5375.05.patch, YARN-5375.06.patch,
> YARN-5375.07-drain-statestore.patch, YARN-5375.07-sync-statestore.patch
>
>
> seen many test failures related to RMApp/RMAppattempt comes to some state but
> some event are not processed in rm event queue or scheduler event queue,
> cause test failure, seems we could implicitly invokes drainEvents(should also
> drain sheduler event) in some mockRM method like waitForState
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
