[
https://issues.apache.org/jira/browse/YARN-5681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15542904#comment-15542904
]
Varun Saxena commented on YARN-5681:
------------------------------------
Thanks [~gtCarrera9] for the patch. The patch does not apply cleanly for me on
top of latest patches on YARN-3359 and YARN-5638. It will be easier to review
if you can update all the patches.
I had a scan through the patch as such though. Few comments thus far :
* In GetTimelineCollectorContextRequestPBImpl, need to set type too in
mergeLocalToBuilder
* In CollectorData, should this be && ?
{code}
88 public boolean stamped() {
89 return (getRMIdentifier() != UNSTAMPED_VERSION_NUMBER)
90 || (getVersion() != UNSTAMPED_VERSION_NUMBER);
91 }
92
{code}
* In NodeHeartbeatRequestPBImpl, any need of setting RM ID and version ? IIUC,
RM will report this in NM heartbeat response. How will NM be knowing about it ?
* In NodeHeartbeatRequestPBImpl, rename addAppCollectorsMapToProto =>
addCollectorsMapToProto
> Change collector discovery to support collectors mapped to clients but not
> applications
> ---------------------------------------------------------------------------------------
>
> Key: YARN-5681
> URL: https://issues.apache.org/jira/browse/YARN-5681
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: timelineserver
> Reporter: Li Lu
> Assignee: Li Lu
> Attachments: YARN-5681-YARN-3359.001.patch
>
>
> As discussed in YARN-3981, we need the service discovery mechanism to map
> collectors with their actual "ids", which may or may not be a concrete
> application Id. This JIRA proposes to generalize the concept of collector id
> in collector service discovery mechanism.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
