[ 
https://issues.apache.org/jira/browse/YARN-5698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15546217#comment-15546217
 ] 

Wangda Tan commented on YARN-5698:
----------------------------------

Thanks [~sunilg] for working on the patch.

Few comments & suggestions:
1) Is it better to rename yarn.resourcemanager.webapp.ui2.enable to 
yarn.webapp.ui2.enable, since the UI is not only for resourcemanager.
2) When RM is runs on the local host, we still need to run {{corsproxy}}. Do 
you know what can we do to fix it?
3) A couple of renames: 
- URL endpoint: /newUI to /ui2 (consistent with config key)
- {{public WebApp start(WebApp webapp, WebAppContext context)}}, context to 
ui2Context

Beyond this, patch looks good. And if you have some bandwidth, could you test 
the patch on a distributed environment?

> [YARN-3368] Launch new YARN UI under hadoop web app port
> --------------------------------------------------------
>
>                 Key: YARN-5698
>                 URL: https://issues.apache.org/jira/browse/YARN-5698
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Sunil G
>            Assignee: Sunil G
>         Attachments: YARN-5698-YARN-3368.0001.patch
>
>
> As discussed in YARN-5145, it will be better to launch new web ui as a new 
> webapp under same old port.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to