[
https://issues.apache.org/jira/browse/YARN-5707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Varun Vasudev updated YARN-5707:
--------------------------------
Attachment: YARN-5707-YARN-3926.003.patch
Thanks for the reviews [~leftnoteasy] and [~asuresh]! Uploaded a new patch with
the fixes -
1) Fixed the license warnings
2)
bq. Think you can remove the default constructor ResourceProfilesManagerImpl()
Fixed
3)
bq. The profiles map can be final and initialized to ConcurrentHashMap.. that
way, you might not need to synchronize all the methods.
Fixed
4)
bq. I feel getResourceProfiles() should not return null... this would place the
burden of checking for null on the client. It would would be better if an empty
map is sent.
Fixed
5)
bq. Rather than explicitly asking the manager to reload, maybe it would be nice
to have a reloading thread that monitors a given file for changes. We do this
in the KMSACLs class.
This was an oversight on my part - the function is meant for testing only. I've
annotated it correctly. Thanks for catching it.
> Add manager class for resource profiles
> ---------------------------------------
>
> Key: YARN-5707
> URL: https://issues.apache.org/jira/browse/YARN-5707
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: resourcemanager
> Reporter: Varun Vasudev
> Assignee: Varun Vasudev
> Attachments: YARN-5707-YARN-3926.001.patch,
> YARN-5707-YARN-3926.002.patch, YARN-5707-YARN-3926.003.patch
>
>
> Add a class that manages the resource profiles that are available for
> applications to use.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
