[
https://issues.apache.org/jira/browse/YARN-5148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15548227#comment-15548227
]
Sunil G commented on YARN-5148:
-------------------------------
Thanks [~lewuathe] for the patch.
New screen shot looks fine for me for metrics.
Few comments on config and log pages.
1. When i visited “Tools” page, there were no default selection for sub tabs..
I think “YARN Configuration” could be made as a default selection
2. I think we can show same *jmx/logs* within same UI template. Even though we
do not need to render cleanly, its better to show within new YARN UI. Currently
its getting redirected to another page and we have click back button from
browser to come back. This may not be a better idea.
Code review:
1. {{adapters/yarn-conf.js}} could extend from {{adapters/abstract.js}}
2. *jmx/logs* could be rendered with plain txt adaptor (similar to
yarn-container-logs)
> [YARN-3368] Add page to new YARN UI to view server side
> configurations/logs/JVM-metrics
> ---------------------------------------------------------------------------------------
>
> Key: YARN-5148
> URL: https://issues.apache.org/jira/browse/YARN-5148
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Wangda Tan
> Assignee: Kai Sasaki
> Attachments: Screen Shot 2016-09-11 at 23.28.31.png, Screen Shot
> 2016-09-13 at 22.27.00.png, YARN-5148-YARN-3368.01.patch,
> YARN-5148-YARN-3368.02.patch, YARN-5148-YARN-3368.03.patch, yarn-conf.png,
> yarn-tools.png
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
