Carlo Curino commented on YARN-5325:

Thanks again for the suggestions.

As per our offline discussion AllocationBookeeper cannot be reinit once and 
forall as the accumulation of weights it does in reinit depends on the 
(possibly changing) set of active subclusters. 

We do log at debug level if the SubClusterResolver throws, but I added a 
if(debug) to avoid costly string construction if we are not in debug mode per 
your advise. 

Using "continue" makes the code much more legible, thanks for the suggestion.

The createResourceRequest is invoked tens of times in 
TestLocalityMulticastAMRMProxyFederationPolicy (now renamed to drop the 
federation), so I would prefer to leave it as is. 

> Stateless ARMRMProxy policies implementation
> --------------------------------------------
>                 Key: YARN-5325
>                 URL: https://issues.apache.org/jira/browse/YARN-5325
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: nodemanager, resourcemanager
>    Affects Versions: YARN-2915
>            Reporter: Carlo Curino
>            Assignee: Carlo Curino
>         Attachments: YARN-5325-YARN-2915.05.patch, 
> YARN-5325-YARN-2915.06.patch, YARN-5325-YARN-2915.07.patch, 
> YARN-5325-YARN-2915.08.patch, YARN-5325-YARN-2915.09.patch, 
> YARN-5325-YARN-2915.10.patch, YARN-5325.01.patch, YARN-5325.02.patch, 
> YARN-5325.03.patch, YARN-5325.04.patch
> This JIRA tracks policies in the AMRMProxy that decide how to forward 
> ResourceRequests, without maintaining substantial state across decissions 
> (e.g., broadcast).

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to