Sangjin Lee commented on YARN-5699:

bq. What about end time? End time has to be get from event time stamp. But 
anyway, I have added a comment for streamlining YARN entities publishing, I 
think we should decide for providing YARN entities converter rather than fixing 
individual many bugs.

Created time is a first-class attribute of an entity, so it would be good to 
use that instead of a generic entity info field. End time is not a first-class 
attribute, so entity info would be a natural place.

Actually let's take one step backward... What is the key benefit for keeping 
most data in event info, rather than in entity info? To me, storing data in 
entity info map looks a good representation that the data "belongs to" the 
whole entity, but not just one event. Even though some data may come from a 
certain type of timeline event, if it adds useful information to the whole 
entity, we should put them in entity info field. I'm not sure if there are some 
implementation side concerns that prevent us from doing this. However, even if 
so, I believe we should fix those blockers but not solve the problem the other 
way around (avoid putting data in entity info, but just put them in event 
info). I would de-prioritize the work on making the v2 code path consistent 
with v1's if this is a problem for our current design.

I'm not so sure if I understand what you meant by this. Are you proposing 
elevating all event info items to the entity info unless they really belong 
only to events? Or are you proposing not to do this work? Bit confused...

> Retrospect yarn entity fields which are publishing in events info fields.
> -------------------------------------------------------------------------
>                 Key: YARN-5699
>                 URL: https://issues.apache.org/jira/browse/YARN-5699
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Rohith Sharma K S
>            Assignee: Rohith Sharma K S
>         Attachments: 0001-YARN-5699.YARN-5355.patch, 0001-YARN-5699.patch, 
> 0002-YARN-5699.YARN-5355.patch
> Currently, all the container information are published at 2 places. Some of 
> them are at entity info(top-level) and some are  at event info. 
> For containers, some of the event info should be published at container info 
> level. For example : container exist status, container state, createdTime, 
> finished time. These are general information to container required for 
> container-report. So it is better to publish at top level info field. 

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to