[ 
https://issues.apache.org/jira/browse/YARN-5708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15570044#comment-15570044
 ] 

Wangda Tan commented on YARN-5708:
----------------------------------

Thanks [~vvasudev], some comments:

- Better to mark unstable for 
GetAllResourceProfilesRequest/GetAllResourceProfilesResponse/GetResourceProfileRequest/GetResourceProfileResponse?
- Mentioned by Arun, it might be better to add some javadocs to 
{{ProfileCapability}}. For example, I'm a little confused why the field 
{{getProfileCapabilityOverride}} has a suffix "Override".
- {{ProfileCapability#getProfile}}, update to {{getProfileName}}?
- Trivial comment: ClientRMService#getResourceProfiles/getResourceProfile can 
be merged.

> Implement APIs to get resource profiles from the RM
> ---------------------------------------------------
>
>                 Key: YARN-5708
>                 URL: https://issues.apache.org/jira/browse/YARN-5708
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: client
>            Reporter: Varun Vasudev
>            Assignee: Varun Vasudev
>         Attachments: YARN-5708-YARN-3926.001.patch, 
> YARN-5708-YARN-3926.002.patch
>
>
> Implement a set of APIs to get the available resource profiles from the RM.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to