Varun Vasudev updated YARN-5708:
    Attachment: YARN-5708-YARN-3926.003.patch

Thanks for the reviews [~leftnoteasy] and [~asuresh]!

One thing I did notice when skimming over the patch is that we should probably 
have a more consistent way for implementing hashcode/equals and toString in our 
PB classes.
We have a bunch of places where the hashcode/equals/toString are implemented in 
the abstract class (for eg. ResourceRequest) and there are places where it is 
defined in the subclass (for eg. ResourceLocalizationRequestPBImpl).
I tend to prefer the latter since it is reverts to the proto/builders 
implementation, which is (can be) auto-generated and something I would trust to 
be correct. The former is hand-coded and error prone.
Agreed. For the PBImpl classes, I've overriden hashCode to use the proto 
hashCode - let me know if I missed any.

bq.  Better to mark unstable for 

bq. Mentioned by Arun, it might be better to add some javadocs to 
ProfileCapability. For example, I'm a little confused why the field 
getProfileCapabilityOverride has a suffix "Override".
My apologies for not providing this upfront. I've added documentation for most 
of the classes, let me know if I missed any.

bq. ProfileCapability#getProfile, update to getProfileName?

bq. Trivial comment: ClientRMService#getResourceProfiles/getResourceProfile can 
be merged.
Fixed - refactored the code to use common functionality.

> Implement APIs to get resource profiles from the RM
> ---------------------------------------------------
>                 Key: YARN-5708
>                 URL: https://issues.apache.org/jira/browse/YARN-5708
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: client
>            Reporter: Varun Vasudev
>            Assignee: Varun Vasudev
>         Attachments: YARN-5708-YARN-3926.001.patch, 
> YARN-5708-YARN-3926.002.patch, YARN-5708-YARN-3926.003.patch
> Implement a set of APIs to get the available resource profiles from the RM.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to