Gour Saha commented on YARN-5729:

[~jianhe] thank you for reviewing the patch.

why is this needed ?
  this.launchTime = (Date) launchTime.clone();
This is to fix the following findbug issues reported by Hadoop QA - 

Does below code need to use the new "getDefaultComponentAsList(Application 
app)" method as well ?
     if (updateAppData.getNumberOfContainers() != null
        && updateAppData.getComponents() == null) {
It does not, since for app update (flex in this case) we use only the container 
count (and don't need artifact, resource and launch cmd). If you see the method 
_*flexSliderApplication*_ you will see that it checks if component-level 
container count is null, in which case it uses the app-level count.

However, I ended up introducing 2 new findbug errors which I am going to fix 
and upload a new 002 patch.

> Bug fixes identified during testing
> -----------------------------------
>                 Key: YARN-5729
>                 URL: https://issues.apache.org/jira/browse/YARN-5729
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Gour Saha
>            Assignee: Gour Saha
>             Fix For: yarn-native-services
>         Attachments: YARN-5729-yarn-native-services.001.patch
> Use this to apply bug fixes identified during testing.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to