[
https://issues.apache.org/jira/browse/YARN-5729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15573365#comment-15573365
]
Gour Saha commented on YARN-5729:
---------------------------------
[~jianhe] thank you for reviewing the patch.
{quote}
why is this needed ?
{noformat}
this.launchTime = (Date) launchTime.clone();
{noformat}
{quote}
This is to fix the following findbug issues reported by Hadoop QA -
https://builds.apache.org/job/PreCommit-YARN-Build/13374/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-applications_hadoop-yarn-services-api-warnings.html#Warnings_MALICIOUS_CODE
{quote}
Does below code need to use the new "getDefaultComponentAsList(Application
app)" method as well ?
{noformat}
if (updateAppData.getNumberOfContainers() != null
&& updateAppData.getComponents() == null) {
updateAppData.setComponents(getDefaultComponentAsList());
}
{noformat}
{quote}
It does not, since for app update (flex in this case) we use only the container
count (and don't need artifact, resource and launch cmd). If you see the method
_*flexSliderApplication*_ you will see that it checks if component-level
container count is null, in which case it uses the app-level count.
However, I ended up introducing 2 new findbug errors which I am going to fix
and upload a new 002 patch.
> Bug fixes identified during testing
> -----------------------------------
>
> Key: YARN-5729
> URL: https://issues.apache.org/jira/browse/YARN-5729
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Gour Saha
> Assignee: Gour Saha
> Fix For: yarn-native-services
>
> Attachments: YARN-5729-yarn-native-services.001.patch
>
>
> Use this to apply bug fixes identified during testing.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
