Varun Saxena commented on YARN-5743:

Thanks [~rohithsharma] for the patch.
Overall the patch looks good.

# Suffixing each metric with _METRIC is not required as we are storing them as 
metric, so its self evident. Its just few extra unnecessary bytes being stored.
# Cosmetic comment - Maybe we can make the formatting of statements inside 
getTimelinelineAppMetrics consistent.

> [Atsv2] Publish queue name and RMAppMetrics to ATS
> --------------------------------------------------
>                 Key: YARN-5743
>                 URL: https://issues.apache.org/jira/browse/YARN-5743
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Rohith Sharma K S
>            Assignee: Rohith Sharma K S
>         Attachments: 0001-YARN-5743.patch
> App queue name is missed to publish to ATSv2. 
> And RMAppMetrcs publish only cpu and memory. There are many more things to 
> publish from app metrics such as 
>  resourcePreempted;
>  numNonAMContainersPreempted;
> numAMContainersPreempted.
> And RMAppMetrics need to be published to App metrics rather than info. 

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to