[
https://issues.apache.org/jira/browse/YARN-5716?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Wangda Tan updated YARN-5716:
-----------------------------
Attachment: YARN-5716.003.patch
Thanks [~jianhe] for reviews,
bq. 1 millisecond ? is this intentional ?
This is to avoid busy loop and pinned on CPU, sleep 1 ms can make CPU usage
close to 0%.
bq. getReservedSchedulerKey vs getAllocatedSchedulerKey: looks like the same ?
Yeah they're similiar, since they're not new from this patch, I prefer to
address this separately.
bq. Too many data structures which wrapps container related info with similar
names: CSAssignment, ContainerAllocation, ContainerAllocationContext,
SchedulerContainer.. could you consolidate these ?
Agree, but I prefer to address them separately,
CSAssignment/ContainerAllocation are not introduced by this patch. Relation
between ContainerAllocationContext and SchedulerContainer is has-more, so we
don't need to consolidate the latter two.
bq. SchedulingPlacementSet has a bunch unused methods and introduced unused
class ResourceRequestUpdateResult, can we add them when needed ?
That is part of the SchedulingPlacementSet definition, I prefer to keep them
here. My next patch will start using it.
Addressed all other comments. (ver.3)
> Add global scheduler interface definition and update CapacityScheduler to use
> it.
> ---------------------------------------------------------------------------------
>
> Key: YARN-5716
> URL: https://issues.apache.org/jira/browse/YARN-5716
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Wangda Tan
> Assignee: Wangda Tan
> Attachments: YARN-5716.001.patch, YARN-5716.002.patch,
> YARN-5716.003.patch
>
>
> Target of this JIRA:
> - Definition of interfaces / objects which will be used by global scheduling,
> this will be shared by different schedulers.
> - Modify CapacityScheduler to use it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
