[
https://issues.apache.org/jira/browse/YARN-4329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15596226#comment-15596226
]
Daniel Templeton commented on YARN-4329:
----------------------------------------
Latest patch looks great. A couple of tiny quibbles:
* These lines {code} boolean nowRunnable =
maxRunningEnforcer.canAppBeRunnable(newQueue,
attempt);{code} can probably be combined into one.
* Your messages {{"User runnable application number has reached its maximum
limit."}} and {{"Queue runnable application number has reached its maximum
limit."}} would be clearer as {{"The user has reached the maximum limit of
runnable applications."}} and {{"The <queue_name> queue has reached the maximum
limit of runnable applications."}}.
* In some of your javadocs you put a newline between the description and
params, and in some you don't. Better to be consistent. I prefer it with the
newline.
> Allow fetching exact reason as to why a submitted app is in ACCEPTED state in
> Fair Scheduler
> --------------------------------------------------------------------------------------------
>
> Key: YARN-4329
> URL: https://issues.apache.org/jira/browse/YARN-4329
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: fairscheduler, resourcemanager
> Reporter: Naganarasimha G R
> Assignee: Yufei Gu
> Attachments: Screen Shot 2016-10-18 at 3.13.59 PM.png,
> YARN-4329.001.patch, YARN-4329.002.patch, YARN-4329.003.patch
>
>
> Similar to YARN-3946, it would be useful to capture possible reason why the
> Application is in accepted state in FairScheduler
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
