[ 
https://issues.apache.org/jira/browse/YARN-4896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15613306#comment-15613306
 ] 

Min Shen commented on YARN-4896:
--------------------------------

The patch looks OK to me.
The unit test failure does not seem to be relevant.
Not sure if the check style warnings are relevant as the link to the output no 
longer works.
Ping [~leftnoteasy] to see if he has any additional comment.

> ProportionalPreemptionPolicy needs to handle AMResourcePercentage per 
> partition
> -------------------------------------------------------------------------------
>
>                 Key: YARN-4896
>                 URL: https://issues.apache.org/jira/browse/YARN-4896
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: capacity scheduler
>    Affects Versions: 2.7.2
>            Reporter: Sunil G
>            Assignee: Sunil G
>              Labels: oct16-easy
>         Attachments: 0001-YARN-4896.patch, 0002-YARN-4896.patch, 
> YARN-4896.0003.patch
>
>
> In PCPP, currently we are using {{getMaxAMResourcePerQueuePercent()}} to get 
> the max AM capacity for queue to save AM Containers from preemption. As we 
> are now supporting MaxAMResourcePerQueuePercent per partition, PCPP also need 
> to handle the same.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to