[
https://issues.apache.org/jira/browse/YARN-4857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15615897#comment-15615897
]
Jason Lowe commented on YARN-4857:
----------------------------------
Thanks for updating the patch!
It looks OK except I noticed we added a bunch of configs to YarnConfiguration
but left all the originals in CapacitySchedulerConfiguration. We either need
to have the CapacitySchedulerConfiguration entries leverage the
YarnConfiguration entries for backwards-compatibility or argue that
CapacitySchedulerConfiguration isn't marked Public and we can just remove those
redundant entries.
It'd be nice to cleanup the java warnings and unused imports as well.
> Add missing default configuration regarding preemption of CapacityScheduler
> ---------------------------------------------------------------------------
>
> Key: YARN-4857
> URL: https://issues.apache.org/jira/browse/YARN-4857
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: capacity scheduler, documentation
> Reporter: Kai Sasaki
> Assignee: Kai Sasaki
> Priority: Minor
> Labels: documentaion
> Attachments: YARN-4857.01.patch, YARN-4857.02.patch,
> YARN-4857.03.patch, YARN-4857.04.patch, YARN-4857.05.patch
>
>
> {{yarn.resourcemanager.monitor.*}} configurations are missing in
> yarn-default.xml. Since they were documented explicitly by YARN-4492,
> yarn-default.xml can be modified as same.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
