[
https://issues.apache.org/jira/browse/YARN-5265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15622995#comment-15622995
]
Sangjin Lee commented on YARN-5265:
-----------------------------------
Thanks [~jrottinghuis] for the patch! I think it's almost there.
(YarnConfiguration.java)
- l.2008-2011: cosmetic: the indentation is off by 1
(TimelineServiceV2.md)
- We might want to say “For example,” before the snippet of the configuration
to make it clearer it is an example value
- l.253-266: the snippet of the configuration should be escaped so as not to
break html. It can be escaped by {{```}} before and after it.
We should look at {{TimelineStorageUtils}} later to see if we can refactor
HBase-related methods into their own. Eventually we should have a clean
separation between generic timeline service code and the HBase-specific code.
> Make HBase configuration for the timeline service configurable
> --------------------------------------------------------------
>
> Key: YARN-5265
> URL: https://issues.apache.org/jira/browse/YARN-5265
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: timelineserver
> Reporter: Joep Rottinghuis
> Assignee: Joep Rottinghuis
> Labels: YARN-5355, oct16-medium
> Attachments: ATS v2 cluster deployment v1.png,
> YARN-5265-YARN-2928.01.patch, YARN-5265-YARN-2928.02.patch,
> YARN-5265-YARN-2928.03.patch, YARN-5265-YARN-2928.04.patch,
> YARN-5265-YARN-2928.05.patch, YARN-5265-YARN-5355.06.patch,
> YARN-5265-YARN-5355.07.patch, YARN-5265-YARN-5355.08.patch,
> YARN-5265-YARN-5355.09.patch, YARN-5265-YARN-5355.10.patch
>
>
> Currently we create "default" HBase configurations, this works as long as the
> user places the appropriate configuration on the classpath.
> This works fine for a standalone Hadoop cluster.
> However, if a user wants to monitor an HBase cluster and has a separate ATS
> HBase cluster, then it can become tricky to create the right classpath for
> the nodemanagers and still have tasks have their separate configs.
> It will be much easier to add a yarn configuration to let cluster admins
> configure which HBase to connect to to write ATS metrics to.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
