On Wed, 2020-12-09 at 16:56 +0100, josef Reidinger wrote: > Hi, > I have PBI with idea that now when we have auto wrapping of lines for > Label widget we could use it for Popup module. Reason is that it is > often constructed and sometimes it include even output of some > command. And if output has too long line, it is not visible. > So idea looks good and when I use it for new Yast2::Popup class it > works fine[1]. But when I try it for old Yast::Popup it is broken[2]. > After debugging it appears it is caused by Stretch[3]. So my question > now is how should I proceed? > Possible options (do not hesitate to write other if I overlook > something): > > 1. have auto wrapping just for Yast2::Popup and has Yast::Popup just > as deprecated legacy class. And if bug report appear about long > unreadable line, just use newer API. > > 2. Remove stretches from Yast::Popup. It can possible break layout > somewhere and probably openQA would need to be adopted. > > 3. similar to 2. just instead of adapting layout, use from > Yast::Popup calls to Yast2::Popup and keep it just as legacy backward > compatible layer. > > As there is a plan to do some changes that affects openqa in January, > I think that deadline to the end of December is good enough. My > preferred solution is 1 as it basically start converging to one API.
I prefer the first option too. Regards. > > Josef > > [1] pr with screenshot: https://github.com/yast/yast-yast2/pull/1122 > [2] pr with changes and screenshot how much it is broken in common > installation: https://github.com/yast/yast-yast2/pull/1121 > [3] pr with screenshot and minimal example for which I can reproduce > it: https://github.com/yast/yast-ycp-ui-bindings/pull/64 > _______________________________________________ > YaST Development mailing list -- [email protected] > To unsubscribe, email [email protected] > List Netiquette: > https://en.opensuse.org/openSUSE:Mailing_list_netiquette > List Archives: > https://lists.opensuse.org/archives/list/[email protected] _______________________________________________ YaST Development mailing list -- [email protected] To unsubscribe, email [email protected] List Netiquette: https://en.opensuse.org/openSUSE:Mailing_list_netiquette List Archives: https://lists.opensuse.org/archives/list/[email protected]
