On Tue, Oct 27, 2009 at 10:17:33AM +0100, Josef Reidinger wrote:
> commit 57ed16912667931726a0d893867f9b096279d82f
> Date:   Tue Oct 27 10:17:08 2009 +0100
> 
>     to submit ensure that changes is saved also to git (use package instead 
> package-local)
> ---
>  webservice-tasks/lib/tasks/submit.rake |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/webservice-tasks/lib/tasks/submit.rake 
> b/webservice-tasks/lib/tasks/submit.rake
> index 81fd20c..3da8f70 100644
> --- a/webservice-tasks/lib/tasks/submit.rake
> +++ b/webservice-tasks/lib/tasks/submit.rake
> @@ -2,5 +2,5 @@ require 'rake'
>  
>  desc 'Submit package to Yast:Web and checks before if it doesn\'t break 
> anything'
>  # just call the checks and then build the package
> -task :submit => [:check_syntax, :test, :restdoc, :"package-local", 
> :build_test, :osc_submit]
> +task :submit => [:check_syntax, :test, :restdoc, :"package", :build_test, 
> :osc_submit]

On Tue, Oct 27, 2009 at 10:18:12AM +0100, Josef Reidinger wrote:
> commit e5ec674aaac328d6c9166197b225b09081deb14f
>  -------------------------------------------------------------------
> +Tue Oct 27 10:17:46 CET 2009 - [email protected]
> +
> +- submit version in git, not local version 
> +
> +-------------------------------------------------------------------

Hi,

when reviewing the osc submission, I thought you were correcting the
packaging of *this gem*.
The change should say "In 'rake submit', use 'package' instead of
'package-local' [so that we don't submit what is not pushed]"

Please take extra care when documenting webservice-tasks, as the gem
packaging is hard to unpack for review :-/

-- 
Martin Vidner, YaST developer
http://en.opensuse.org/User:Mvidner

Kuracke oddeleni v restauraci je jako fekalni oddeleni v bazenu

Attachment: pgpOqrQcRtV9B.pgp
Description: PGP signature

Reply via email to