Hi, Johannes, 

> Author: jsmeix
> Date: Fri Dec 18 14:43:50 2009
> New Revision: 60152
> 
> URL: http://svn.opensuse.org/viewcvs/yast?rev=60152&view=rev
> Log:
> 
> I was almost toast in the encoding hell but it seems
> now the percent encoding stuff works, see bnc#561626

Now this is how a scarry svn commit looks like ;-)
I did not look much into the details of special char escaping you implemented 
for the y2-printer, but I was wondering - did you check what's provided by  
existing URL.ycp module? This one: 
http://forgeftp.novell.com/yast/doc/SL11.2/modules/URL.html

It implements some Escape and UnEscape functions you might find useful, 
without re-cycling pretty much the same code in printer again. If you find 
those not satisfactory, maybe you could extend the existing functionality in 
URL.ycp so that everyone can benefit from it.

So short ...

fB.

>  ==========================================================================
> ==== --- trunk/printer/src/connectionwizard.ycp (original)
> +++ trunk/printer/src/connectionwizard.ycp Fri Dec 18 14:43:50 2009
> @@ -43,88 +43,218 @@
>  string connection_uri="";
>  string connection_model="";
>  
> -// Map of reserved URI characters ! # $ % & ' ( ) * + , / : ; = ? @ [ ]
> -// plus the space character and their matching percent encoding
> +// List of reserved URI characters ! # $ % & ' ( ) * + , / : ; = ? @ [ ]
> +// (the % character is separated as percentage_percent_encoding)
> +// plus the space character and their matching percent encodings
>  // where each percent encoding must be exactly three characters
> -// and uppercase letters, otherwise URIpercentDecoding will not work:
> -map< string, string > uri_percent_encodings = $[ " ":"%20",
> -                                                 "!":"%21",
> -                                                 "#":"%23",
> -                                                 "$":"%24",
> -                                                 "&":"%26",
> -                                                 "'":"%27",
> 
-- 
  \\\\\              Katarina Machalkova    
  \\\\\\\__o          YaST developer
__\\\\\\\'/_          & hedgehog painter

Attachment: signature.asc
Description: This is a digitally signed message part.

Reply via email to