On Mon, Jul 25, 2011 at 05:27:03PM +0200, Justus Winter wrote:
> Hey everyone :)
> 
> I noticed that the ipaddr wasn't decomposed into IP and prefix in
> writeInterfaces so the IPADDR field contained both the IP and the
> prefix and the PREFIXLEN was left empty.
> 
> This seems to cause little problems in practice since most of the time
> both variables are concatenated again, but if you set the IP address
> using YaPI and read it out again (also using YaPI) you ended up with a
> string containing an extra trailing /. I think this is why the yast web
> client code contains lots of .delete("/") in network_controller.rb.
> 
> The attached patch fixes this problem.

Thank you for the patch!

Actually, the form that Write uses is a valid one according to
ifcfg(5), so we need to fix Read instead. I am writing some more
test cases for it too.

-- 
Martin Vidner, YaST developer
http://en.opensuse.org/User:Mvidner

Kuracke oddeleni v restauraci je jako fekalni oddeleni v bazenu

Attachment: pgpwI6pg10IqJ.pgp
Description: PGP signature

Reply via email to