Dne 13.10.2011 15:35, [email protected] napsal(a): > + /* > + l = maplist(map<string, any> m, l, { > + return filter(string k, any v, m, { > + return contains([ "channel", "dev_name" ], k); > + }); > }); > + */
Avoid commenting dead code, just remove it (it's still in SVN history if you need to recover it later, just use a descriptive commit message so you can later find it easily) (IMO commenting is acceptable if you need to temporarily disable some code. But don't forget to add some FIXME comment why it was disabled in that case.) > + return $[ "devices" : l ]; Oh! At first sight I was wondering why number one was returned here, then I noticed that there is "l" (letter L) not "1" (one). In fixed font in my email client they look very similar... Use more descriptive variables if possible, especially when a typo can be overlooked like in this case... -- Ladislav Slezák Appliance department / YaST Developer Lihovarská 1060/12 190 00 Prague 9 / Czech Republic tel: +420 284 028 960 [email protected] SUSE -- To unsubscribe, e-mail: [email protected] To contact the owner, e-mail: [email protected]
