Dne 2.11.2011 14:51, [email protected] napsal(a):
> Author: locilka
> Date: Wed Nov 2 14:51:17 2011
> New Revision: 66662
>
> URL: http://svn.opensuse.org/viewcvs/yast?rev=66662&view=rev
> Log:
> - Unified starting, stopping and checking for firewall status
>
> (bnc#727445)
>
> - //if (Mode::normal() || Mode::commandline()) {
> - foreach (string service, firewall_services, {
> - if (Service::Status(service) == 0) {
> - started = true;
> - break;
> - }
> - });
> - //}
> + if (Mode::testsuite()) return true;
>
WATCH OUT! This breaks many testsuites!!
E.g. in yast2-nis-client, yast2-nfs-client, yast2-nfs-server, see
https://build.opensuse.org/project/monitor?project=YaST%3AHead
Their tests expect the call in the output, they fail with this diff:
-Execute .target.bash "/sbin/service SuSEfirewall2_init status"
$["TERM":"raw"] 0
Either fix the code or the affected tests.
--
Best Regards
Ladislav Slezák
Yast Developer
------------------------------------------------------------------------
SUSE LINUX, s.r.o. e-mail: [email protected]
Lihovarská 1060/12 tel: +420 284 028 960
190 00 Prague 9 fax: +420 284 028 951
Czech Republic http://www.suse.cz/
--
To unsubscribe, e-mail: [email protected]
To contact the owner, e-mail: [email protected]
