Hi, small note: On Tue, 22 Nov 2011 20:00:52 -0000 [email protected] wrote:
> Author: thardeck > Date: Tue Nov 22 21:00:51 2011 > New Revision: 66894 > > URL: http://svn.opensuse.org/viewcvs/yast?rev=66894&view=rev > Log: > - fixed wrong Yast categories for IUCV terminal modules (fate#310723) > - fixed disabling of the IUCV input field in the ncurses dialog > (fate#310723) > - check z/VM ids against username specification to prevent umlauts > > @@ -754,7 +754,8 @@ > integer line = 0; > foreach (string zvmid, zvmid_list,{ > line = line + 1; > - if (regexpmatch(zvmid, "[^[:alnum:]]")) > + // since alnum allows umlauts too the id is checked > against the user name specification > + if (regexpmatch(zvmid, "[^[:alnum:]]") || > (!IUCVTerminalServer::CheckUserGroupName(zvmid) && zvmid != "")) { If you have method to check username by specification, then regexmatch looks useless for me and just call check is enough. Also checkusernamegroup should check if zvmid is empty, if it is againts specification. Josef -- To unsubscribe, e-mail: [email protected] To contact the owner, e-mail: [email protected]
