On Thu, 25 Feb 2016 17:13:30 +0100 Ladislav Slezak <[email protected]> wrote:
> Dne 25.2.2016 v 03:59 [email protected] napsal(a): > > Pending requests in repository yast-bootloader: > > - [do not merge] partial usage of config files gem (20 days) > ^^^^^^^^^^^^ > [...] > > Pending requests in repository yast-snapper: > > - [DO NOT MERGE] Added snapshot Class with strategy pattern. (82 > > days) > ^^^^^^^^^^^^ > [...] > > Pending requests in repository aytests-tests: > > - [do not merge] Installation rules (12 days) > ^^^^^^^^^^^^ > > > Um, maybe we should improve the pull request checker to ignore the > pull requests which contain "do not merge" or "WIP" texts, usually > these requests are proof of concepts or unfinished work. > > I personally skip these requests automatically and do not check them > at all. > > On the other hand it makes sense to check such requests from time to > time to avoid rotting branches and requests... > > What do you think about it? I am also considering it now as I usual round of pinging. And to be honest I think it make sense to also check such do not merge pull request otherwise it get lost quickly. Inactivi means also that noone do any commit to such branch for given time, so it is no merge and no update, which is wrong for me. For bootloader it indicate that I have vacation. For snapper I discuss it with Knut and for autoyast I try to get situation. So we can add more logic like more relaxed time for inactivity if such flag is there, but it make script more complex, so maybe it will be better to just keep it as it is. But this mails is for everyone, so if others agreed to change it, I can do it. Josef -- To unsubscribe, e-mail: [email protected] To contact the owner, e-mail: [email protected]
