On 15.11.2016 12:47, Josef Reidinger wrote: > Hi, > currently as I touch warning levels in proposal clients I get idea to a > bit unify that levels to make it easier to use it, test it and also > simplify handling code in proposal runner. > > What are current levels: > > notice: only one that is not in red color > warning: just shown > error: now ask user to continue even with it > blocker: block clicking on Install/Update button > fatal: beside blocking also stop evaluation other proposals
Yes, we've discussed that five is just too much and too confusing > My suggestion is: > > drop notice level ( when passed, do not display it, just throw it away ) Then we should at least log it, exception might be too much though > merge warning and error into one warning with current behavior of error Well, it's not an error, it's a warning as you can continue > merge blocker and fatal into one fatal with current behavior of fatal Here 'Error' would be better, but as we merge only 'Fatal' and 'Blocker', then we can't switch to 'Error', so good choice. > current usage of levels in git checkout: > > notice: 0 --> nothing, nice > warning: 11 > error: 3 --> warning (just 3 errors and you can skip them anyway) > blocker: 17 > fatal: 5 --> blocking anyway > and when we talk about API of this call. I also do not like ability to > allow only one warning with level. So e.g. if bootloader find two > problems, then only one can be shown to user with only one level. > > So I also propose to introduce new key in description map like > "warnings" that contain pairs of [level, msg] so more warnings can be > given. I'm always a bit confused with "warnings" if these are actually "messages", so why not "messages"? > What do you think about it? Of course old symbols will be marked as > deprecated and also logged that it is deprecated and removed in SLE13? Good solution. So, the target is CASP and/or SLE 12 SP3? Thx Lukas -- Lukas Ocilka, Systems Management (Yast) Team Leader SLE Department, SUSE Linux Sent from my openSUSE Tumbleweed https://en.opensuse.org/Portal:Tumbleweed -- To unsubscribe, e-mail: [email protected] To contact the owner, e-mail: [email protected]
