On Thu, 2019-12-05 at 15:23 +0000, José Iván López González wrote: > I would also avoid to use meta-programming magic like that. Sooner > than > later it will bite your ass ;). Moreover (and even though it is not > published in any official place yet) we have some namespace > conventions > for the new code [1], for example Y2Storage, Y2ServicesManager, > Y2Firewall, Y2Network, etc. So the new code will not live under Yast > namespace anymore and it will not be directly affected by this > problem. > > For older code, I would follow the Josef's suggestion: to use the > scope > resolution operator to always start from the global scope (e.g., > ::FileUtils).
I usually try to avoid meta-programming, but in this case it does not look that dangerous to me :) It is true that it does not make sense for the new code, good point. On the other hand, it could save us (and our users) from some crashes. However, I guess that as a first step we should do a quick research about the usage of FileUtils in the current code base and then decide how to proceed (if we decide to do something). The time between the end of this sprint and the start of the holidays looks like a good moment to me :) Regards, Imo -- Imobach González Sosa YaST Team at SUSE LINUX GmbH https://imobachgs.github.io/
signature.asc
Description: This is a digitally signed message part
