Review: Approve Hi Benji,
The Pythonization is great and overdue! And thanks for setting up a testing structure. typo: s/about to being/about to begin/ (Several occurrences.) line 119 is missing a comma, as I found out the hard way. In my branch I've moved the definition of 'log' into the helpers.py. DRY. The sleep at 431 seems awful aggressive given the long time it takes to deploy. A lot of install and config-changed hooks I've already modified, so they were not reviewed too closely. -- https://code.launchpad.net/~benji/charms/oneiric/buildbot-master/buildbot-master-lpbuildbot/+merge/91323 Your team Launchpad Yellow Squad is subscribed to branch lp:~yellow/charms/oneiric/buildbot-master/trunk. -- Mailing list: https://launchpad.net/~yellow Post to : [email protected] Unsubscribe : https://launchpad.net/~yellow More help : https://help.launchpad.net/ListHelp
