Review: Approve code Hi this branch looks good.
I was a bit confused by the trailing '--' in the ssh command set up. It appears to be undocumented and unnecessary. Unless you have a reason that it must be there, please delete or comment its use. The duplication of the juju_wrapper is also thorny. I checked around jelmer's work on bzr nested trees is not yet ready. I'm at a loss for a workable solution to these shared files. Very annoying. Since this branch is self-contained and no one depends on it I am not going to merge it today (as I did for branches yesterday). -- https://code.launchpad.net/~frankban/charms/oneiric/buildbot-slave/02-09/+merge/92340 Your team Launchpad Yellow Squad is subscribed to branch lp:~yellow/charms/oneiric/buildbot-slave/trunk. -- Mailing list: https://launchpad.net/~yellow Post to : [email protected] Unsubscribe : https://launchpad.net/~yellow More help : https://help.launchpad.net/ListHelp
