> As we discussed on IRC please comment why you use flush() on the temporary > file so someone doesn't inadvertantly "fix" it.
I added a comment explaining the apparent oddity. > We also discussed how our test method encode_file doesn't work in the manner > we'd use in real life so it may be better to rewrite it to use the UNIX > 'base64' command. We used to suggest 'uuencode' which didn't work with our > decoding. So I do think we should test the method we suggest people use. Yep, we should have a test like that. If we don't remove the need for base64 encoding alltogether, I'll add one in another branch. -- https://code.launchpad.net/~benji/charms/oneiric/buildbot-master/tests-with-config-up-front/+merge/92377 Your team Launchpad Yellow Squad is subscribed to branch lp:~yellow/charms/oneiric/buildbot-master/trunk. -- Mailing list: https://launchpad.net/~yellow Post to : [email protected] Unsubscribe : https://launchpad.net/~yellow More help : https://help.launchpad.net/ListHelp
