Review: Approve code Francesco the changes look nice. Moving make_charm_config_file to a shared spot is a good call.
Also the fix to 'su' seems to be good. I see we have no test for that context manager, though. Should be easy to do. Would you mind adding a couple, including one that shows the proper handling in the event of an exception? -- https://code.launchpad.net/~frankban/charms/oneiric/buildbot-master/helpers-fixes/+merge/92534 Your team Launchpad Yellow Squad is subscribed to branch lp:~yellow/charms/oneiric/buildbot-master/trunk. -- Mailing list: https://launchpad.net/~yellow Post to : [email protected] Unsubscribe : https://launchpad.net/~yellow More help : https://help.launchpad.net/ListHelp
