https://codereview.appspot.com/6724059/diff/5002/app/views/service.js File app/views/service.js (right):
https://codereview.appspot.com/6724059/diff/5002/app/views/service.js#newcode655 app/views/service.js:655: charm: renderableCharm} the charm is referenced by id only in the templates, so all of these only need charm_id: service.get('charm') ie. the renderable_charm call here is extraneous. https://codereview.appspot.com/6724059/diff/5002/app/views/service.js#newcode822 app/views/service.js:822: var renderableCharm = this.renderable_charm(service.get('charm'), renderableCharm/renderedCharm these lines could be removed afaics, and made internal to the getServiceTabs and since its only needs app.getModelURL(this.get('charm')) the call to renderable_charm can be omitted. https://codereview.appspot.com/6724059/ -- https://code.launchpad.net/~tveronezi/juju-gui/service-header/+merge/130243 Your team Juju GUI Hackers is requested to review the proposed merge of lp:~tveronezi/juju-gui/service-header into lp:juju-gui. -- Mailing list: https://launchpad.net/~yellow Post to : [email protected] Unsubscribe : https://launchpad.net/~yellow More help : https://help.launchpad.net/ListHelp
