There's still some minors in the this branch fwiw.. Relation cancel text should read 'Cancel' not 'None'. The pending relation line should continue to be displayed while the pending display menu is active. The relation pairs shoulds shown should be sorted (deterministic order), and there's no need to indent the pairs.
-k On Sat, Oct 20, 2012 at 8:21 PM, Matthew Scott <[email protected]>wrote: > *** Submitted: > > Implement ambiguous relation menu for adding rels > > Displays a menu of choices when adding a relation between two services > would result in ambiguity, otherwise simply adds a relation. Also, a > bit of minor test clean-up in charm config, due to floating point > inequality. > > R=thiago, benjamin.saller, hazmat > CC= > https://codereview.appspot.com/6736051 > > > https://codereview.appspot.com/6736051/ > > -- > > https://code.launchpad.net/~makyo/juju-gui/ambiguous-relations/+merge/130616 > Your team Juju GUI Hackers is requested to review the proposed merge of > lp:~makyo/juju-gui/ambiguous-relations into lp:juju-gui. > -- https://code.launchpad.net/~makyo/juju-gui/ambiguous-relations/+merge/130616 Your team Juju GUI Hackers is requested to review the proposed merge of lp:~makyo/juju-gui/ambiguous-relations into lp:juju-gui. -- Mailing list: https://launchpad.net/~yellow Post to : [email protected] Unsubscribe : https://launchpad.net/~yellow More help : https://help.launchpad.net/ListHelp
